Forum

CS2D

Scripts

Concatenate a boolean value, Lua Error

Forums overview CS2D overview Scripts overview Log in to reply

Concatenate a boolean value, Lua Error

8 replies

Concatenate a boolean value, Lua Error

Cebra
User Off

Offline

16.01.16 05:38:31 pm

1
2
3
4

LUA ERROR: sys/lua/autorun/playermenu.lua:10: attempt to
concatenate a boolean value-> sys/lua/autorun
/playermenu.lua:10: in function <sys/lua/autorun
/playermenu.lua:2>-> in Lua hook 'serveraction', params: 1, 1

i get this error message sometimes, when i try my script
then, a few moments later, it works again.
What i can do?

Atomic

Re: Concatenate a boolean value, Lua Error

GeoB99
Moderator Off

Offline

16.01.16 05:41:56 pm

Would you mind post the code? We cannot help you if you don't show us the bugged script code.

Re: Concatenate a boolean value, Lua Error

VADemon
User Off

Offline

16.01.16 06:00:16 pm

I believe player() sometimes returns a boolean false when the return value is supposed to be invalid. That may be one of the reasons.

Re: Concatenate a boolean value, Lua Error

Cebra
User Off

Offline

16.01.16 06:36:03 pm

thats is the complete script

Spoiler

Re: Concatenate a boolean value, Lua Error

EngiN33R
Moderator Off

Offline

16.01.16 06:58:18 pm

for i=1,#(player(0,"table")) do

This piece of code iterates over all existing players, sure, but it only gets the indices of the player table - the indices aren't always equal to their values when it comes to player IDs. A better way would be to write the code like this:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50

addhook("serveraction","pm")
function pm(id,act)
     if act==1 then
          s1="Player Menu 1"
          s2="Player Menu 2"
          s3="Player Menu 3"
          s4="Player Menu 4"
          for k, v in pairs(player(0,"table")) do
               if k<=8 then
                    s1=s1..","..player(v,"name")
               end     
               if k==9 then
                    s1=s1..",Next"
               end
               if k>8 and k<17 then
                    s2=s2..","..player(v,"name")
               end
               if k==17 then
                    s2=s2..",Next"
               end
               if k>16 and k<25 then
                    s3=s3..","..player(v,"name")
               end
               if k==25 then
                    s3=s3..",Next"
               end
               if k>24 then
                    s4=s4..","..player(v,"name")
               end
          end
          menu(id, s1)
     end
end

addhook("menu","pm2")
function pm2(id,title,buton)
     if title=="Player Menu 1" then
          if buton==9 then
               menu(id,s2)
          end
     elseif title=="Player Menu 2" then
          if buton==9 then
               menu(id,s3)
          end
     elseif title=="Player Menu 3" then
          if buton==9 then
               menu(id,s4)
          end
     end
end

Though to be fair, the script has a couple of weak points and could do with a rewrite.

Re: Concatenate a boolean value, Lua Error

VADemon
User Off

Offline

16.01.16 07:00:10 pm

Cebra: That's what I predicted in my last reply. You have to check first if the player(i,"exists") and only then add his name to the table.

However, I recommend you to use UniMenu 2 for creating menus.

Re: Concatenate a boolean value, Lua Error

Cebra
User Off

Offline

16.01.16 07:05:32 pm

thank you all,
@ user

VADemon: i learn at the moment lua and i wrote this to train, but thank you for the link, i will look for it later,

@ user

EngiN33R: yes there are mistakes in but the most i write in a few min and the help of bowlinghead

'k' var is like the 'i' in my script and the 'v' have the value of the actual table content, right?

edited 1×, last 17.01.16 04:13:15 pm

Re: Concatenate a boolean value, Lua Error

Rainoth
Moderator Off

Offline

17.01.16 08:04:22 pm

k is the index in table, v is the value marked with that index in table
for example, index 5 means it's 5th in the table,
for example, value "potato" means that there's "potato" in 5th spot in the table.
the way you loop i is very different, you're getting numbers from 1 to whatever length is, so you may not even get proper numbers.
for example:
playertable = {10, 5, 3, 4}
the values of players (this is very simplified because players actually have tables of values and not just random numbers) are like I wrote above, like lets say it's how much health they have (one has 10, the other has 5, then 3 and finally the last player has 4)
All the players joined one after another so they're index like so:
[1] = 10,
[2] = 5,
[3] = 3,
[4] = 4
when you loop with i, you get the length. The script gets the length (4) because there's 4 players and loops: 1,2,3,4. Great!
Player 3 leaves...
Now everything looks like this.
[1] = 10,
[2] = 5,
[4] = 4
You loop i again and get the length (3) because there's 3 players. Now you loop: 1,2,3 ??? 3 does not exist (because he left earlier) and 4 wasn't even looped (because table length does not reach the highest id).
*Sad trombone*

Which is why you should use pairs, it returns index and value of table correctly, even if the player (who say is #3) left.
If you check if player(i,"exists"), sure it'll prevent trying to do crap for nonexistent players, but it still won't loop all players and thus may not do what you aim to do in your code.

Re: Concatenate a boolean value, Lua Error

Cebra
User Off

Offline

17.01.16 08:46:20 pm

Okay ty